fix Insert method

MeilCli · Apr 2, 2017 · 7e4a69e · 7e4a69e
1 parent f0f67dc
commit 7e4a69e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/Source/Plugin.CrossFormattedText.Abstractions/FormattedString.cs b/Source/Plugin.CrossFormattedText.Abstractions/FormattedString.cs
@@ -63,6 +63,14 @@ internal CharSpan[] ToCharSpanArray() {
             return ar;
         }
 
+        internal Span[] ToClonedSpanArray() {
+            var ar = new Span[spans.Length];
+            for(int i = 0;i < spans.Length;i++) {
+                ar[i] = spans[i].Clone();
+            }
+            return ar;
+        }
+
         internal FormattedString MergeCharSpan(CharSpan[] newSpans) {
             var list = new List<Span>();
             Span currentSpan = null;
@@ -209,11 +217,12 @@ public FormattedString Insert(int insertIndex,Span value) {
                 throw new ArgumentNullException(nameof(value));
             }
 
+            Span[] sAr = ToClonedSpanArray();
             Span[] nAr = new Span[spans.Length + 1];
             Span newSpan = value.Clone();
 
-            Array.Copy(spans,nAr,insertIndex);
-            Array.Copy(spans,insertIndex,nAr,insertIndex + 1,spans.Length - insertIndex);
+            Array.Copy(sAr,nAr,insertIndex);
+            Array.Copy(sAr,insertIndex,nAr,insertIndex + 1,sAr.Length - insertIndex);
             nAr[insertIndex] = newSpan;
 
             return new FormattedString(nAr);

diff --git a/Test/Test.CrossFormattedText.Unit/FormattedStringTest.cs b/Test/Test.CrossFormattedText.Unit/FormattedStringTest.cs
@@ -92,6 +92,7 @@ public void InsertTest() {
             var newText3 = Text.Insert(1,span);
             Assert.AreEqual(newText3[1].Equals(span),true);
             Assert.AreEqual(newText3.Length,Text.Length + 1);
+            Assert.AreEqual(Text.AnySpanReferenceEquals(newText3),false);
         }
 
         [TestMethod]