Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
setup.py
importstorch
YOLOX/setup.py
Line 8 in 6819425
installing
yolox
requires a separate install oftorch
beforehand (as documented in the README). However, there is a standard way to include build dependencies for a Python package. From the PyPA docs:Adding
pyproject.toml
with abuild-system.requires
section that includestorch
would eliminate the need to installtorch
with a separate command prior to installingyolox
. (Importantly, this only installstorch
during the build stage, it still needs to be installed into the Python environment to use the package). This makes it easier to use a library in other packages.For example, the following fails:
Whereas this succeeds: