Repository navigation
Conversation
A refused batch is loaded again with the JIT off, in case the JIT is what the loader objects to. When that retry is refused as well the JIT is not the cause, yet it stayed off for the rest of the process. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the loader refuses a batch,
retryWithoutJitloads it again with the JIT off, in case the JIT is what it objects to. When that retry is refused as well, the JIT is not the cause, yet it stayed off (jit = false) for the rest of the process. It is now turned back on, andCompiler.jitstays true.Tests
LoadFailureTest.bootThrow. A refusal that survives the retry needs a module the loader refuses with and without the JIT: here a static initialiser that throws only when the compiled module boots, the flag being set afterenv.start()so the interpreted run passes. Without the fix,the JIT is still onfails.test/run.sh eval cpp: 421 / 421 / 454 passed (upstream: 421 / 421 / 451). Conformance columns (eval-interp, hxcpp-interp, hxcpp-cppia, hxcpp-cppia-jit) and the frontier are unchanged.Playground,Shapes) as upstream. HashLink not run.