Skip to content

Conversation

@stsrki
Copy link
Collaborator

@stsrki stsrki commented Mar 9, 2023

Closes #4660

@stsrki stsrki requested a review from David-Moreira March 9, 2023 13:59
@David-Moreira
Copy link
Contributor

I guess the real problem here, is that we were using DI for an internal member. But I guess it's necessary to easily get the benefit of scoping it. So from a api design perspective maybe we shouldn't have to change it to public on purpose.
But I guess it's the easier route and there's no real harm on it, so LGTM.

@stsrki
Copy link
Collaborator Author

stsrki commented Mar 9, 2023

I guess the real problem here, is that we were using DI for an internal member. But I guess it's necessary to easily get the benefit of scoping it. So from a api design perspective maybe we shouldn't have to change it to public on purpose. But I guess it's the easier route and there's no real harm on it, so LGTM.

This should get easier once we do the Blazorise packages for testing.

@stsrki stsrki merged commit 4d2bb12 into rel-1.2 Mar 9, 2023
@stsrki stsrki deleted the rel-1.2-public-ModalSharedContext branch March 9, 2023 14:26
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants