2 minor changes #15
Open
2 minor changes #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added ability to pass multiple or single directory to compile command. added check to see if output directory exists and if not create it.
| //check if directory to which compiled soy files will be written exists | ||
| if (!fs.existsSync(outputDirectory)) { | ||
| //create directory if not. | ||
| fs.mkdirSync(outputDirectory) |
There was a problem hiding this comment.
You might want to use mkdirp instead, so that it'll create the directory recursively.
|
Thanks for the patch, would you mind signing the Contributor Licence Agreement: https://github.com/Obvious/open-source#note-to-external-contributors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"added ability to pass multiple or single directory to compile command. added check to see if output directory exists and if not create it."
The reason behind the multiple directories is because we generate vast amounts of templates and then override delegates in another location.