Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add possibility for the user to custom the skipped interfaces #63

Merged
merged 32 commits into from
Dec 22, 2020

Conversation

pdedumast
Copy link
Member

No description provided.

@pdedumast pdedumast changed the title 27 custom skipped interfaces [ENH] Add possibility for the user to custom the skipped interfaces Dec 9, 2020
@sebastientourbier
Copy link
Member

sebastientourbier commented Dec 15, 2020

@pdedumast If needed I activated the generation of the doc for this branch. It can be viewed at https://mialsrtk.readthedocs.io/en/27_custom_skipped_interfaces/

@sebastientourbier sebastientourbier added this to the v2.0.1 milestone Dec 15, 2020
@sebastientourbier sebastientourbier added big-effort enhancement New feature or request labels Dec 15, 2020
Copy link
Member

@sebastientourbier sebastientourbier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ready to be merged !
Great job @pdedumast !
For the future, we should have in mind to set skip_stacks_ordering to false in the configuration file (we could also make two different configuration files) otherwise this decreases code coverage.

@pdedumast
Copy link
Member Author

For the future, we should have in mind to set skip_stacks_ordering to false in the configuration file (we could also make two different configuration files) otherwise this decreases code coverage.

@sebastientourbier Indeed, skip_stacks_ordering=False is the default value.
I did not mean to commit the json parameter file, this is a mistake. Though, as how it is implemented now, the list of output files will not be modified when switching skip_stacks_ordering on and off.

@pdedumast
Copy link
Member Author

@sebastientourbier seems that old required tests are blocking the possibility to merge. Any idea?

@sebastientourbier sebastientourbier merged commit fd93c69 into v2.0.1-dev Dec 22, 2020
@sebastientourbier sebastientourbier deleted the 27_custom_skipped_interfaces branch December 22, 2020 17:15
@sebastientourbier
Copy link
Member

@sebastientourbier seems that old required tests are blocking the possibility to merge. Any idea?

Yes, for the moment I need to force the merge. That's what I did ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big-effort enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement functionality to specify interfaces to be connected in the workflow in the parameter file
2 participants