Skip to content

[contribution-issue-315] Fix column filtering while on page > 1 (mari… #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

[contribution-issue-315] Fix column filtering while on page > 1 (mari… #319

merged 1 commit into from
Jan 5, 2022

Conversation

@marionfromfrance
Copy link
Contributor

@marionfromfrance marionfromfrance commented Oct 11, 2021

use $this->setPage() WithPagination Trait method instead of modifying the $page attribute

@marionfromfrance
Copy link
Contributor Author

marionfromfrance commented Oct 11, 2021

Hi,
the following livewire commit introduces a problem when filtering on a column while we are on another page than number 1 : livewire/livewire@52a8605
Using the $this->setPage() WithPagination Trait method instead of modifying the $page attribute resolves the problem.

@marionfromfrance marionfromfrance mentioned this pull request Oct 11, 2021
Closed
@marionfromfrance marionfromfrance mentioned this pull request Nov 15, 2021
Closed
@marksalmon marksalmon merged commit 955dd92 into MedicOneSystems:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marionfromfrance @marksalmon