Extract default CSS classes to config. #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracting the default CSS classes applied by the rowClasses() and cellClasses() methods so it's easier to globally change the style. Added a short hint in the readme. Also added some comments to the config file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About styling... I agree with your principles as described in the README, but i do think it's easier if the hardcoded classes in the code could be set by default in the config instead of overriding the methods on every datatables component. This makes it easier to apply your own style and makes the code look a bit cleaner on your project.
Because of that i made the following changes:
As this is my first pull request to an open-source project ever (better late then never), please let me know if i'm doing something you don't like :-) I'm here to learn!