Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new PhotonStructDecoder #181

Draft
wants to merge 3 commits into
base: new-ui
Choose a base branch
from

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Sep 11, 2024

Closes #181

Still TODO:

  • Verify schema hashes
  • Actually plumb this into the rest of the code
  • Allow PhotonStructDecoder to use normal Struct types as nested members
  • Guarantee that float64 x; and double x; hash to the same thing

It's not pretty, but for an MVP it's not bad
image
#181

@mcm001
Copy link
Contributor Author

mcm001 commented Sep 12, 2024

I can't drag and drop Translation/Transform3ds onto the field, but it seems like all other decoding works. the bytes consumed member also needs to be trimmed off.
https://github.com/user-attachments/assets/5d2ac990-479b-4545-9616-df84dd5b814d

@mcm001 mcm001 changed the base branch from main to new-ui September 13, 2024 05:34
@mcm001
Copy link
Contributor Author

mcm001 commented Sep 13, 2024

This should be like 90% of the way to feature complete, but I haven't had a chance to go through and clean-up code yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant