GPU fully compiling #389
Merged
GPU fully compiling #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mapobjective gpu
Small sigmoid la gpu fix
Fix viewtype tohost
dannys4
requested changes
Feb 14, 2024
|
Last comment: it looks like, in the github actions, the new SetCoeffs breaks Julia due to function call ambiguity; this should be fixed by just separating out the lines like Kokkos::View<const double*, MemorySpace> const_coeffs = JlToKokkos(coeffs);
pfb.SetCoeffs(const_coeffs); |
dannys4
added a commit
that referenced
this pull request
Mar 25, 2024
* Fix SetCoeffs * fixed ParameterizedFunctionBase bugs * added missing templates * fixed SetCoeff bugs * fixed wrapCoeffs * implemented wrapCoeffs with shallow copy * used correct WrapCoeffs function for eigen vector coeffs * fixed gpu bug in ConditionalMapBase * conditional map base gpu bug fix * removed unnecissary function * ConditionalMapBase gpu bug fix (#373) * fixed gpu bug in ConditionalMapBase * conditional map base gpu bug fix * removed unnecissary function * fixed wrap coeffs gpu error in ComposedMap * working on composedmap setCoeffs bug * Merge changes from main (#379) * fixed Summarized Map GPU bug * fixed MapFactory GPU bugs * Standardized notation * ComposedMap, SummarizedMap, and MapFactory GPU bug fixes (#382) * MapFactoryImpls compiling * addec correct space when using gpu * main library compiles with gpu * Fixing some small gpu issues * MapFactoryImpl Fixes (#387) * GPU fully compiling (#389) * Pass tests on gpu (#390) * removed comments * added functor * fixed functor * Fixing MapObjective * added non const set coeffs function * fixed non kokkos inline function error * Fixing sigmoid.h and small LA * working on tohost * Fix viewtype tohost * added documentation for array conversions * removed documentation for array conversions * fixed commenting bug * moved comments * updated setcoeffs and documentation * fixed julia binidngs error * removed virtual from non virtual setCoeffs * fixed julia binding error * fixed julia binding error part2 * fixed undefined device space * renamed device space tests * Adding new policy fixes * started fixing kokkos parallel for issues * continued updating parallel for * updating parallel_for in tests * updated parallel reduce * Fix warnings, format * Fix density errors * Compiling RunTests * Working tests * Fix serial codebase * Compiling Serialization and python * Fixing mapfactoryimpl warnings * Working python bindings * fixing git issues * fixed binding templating * Finish gpu compile (#394) * Fix loop in innermarginalaffine * Remove unused variables * Fix GPU and Test warnings/errors * Test sigmoids on GPU * Working python bindings for device sigmoid component * Fix CPU compile error * Fix test_MC * fixed Multivariate Test --------- Co-authored-by: Daniel Sharp <dannys4@mit.edu> Co-authored-by: MMRROO <mrowkamaad@gmail.com> Co-authored-by: Matt Parno <parnomd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.