Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 improve time operators performance #7

Merged
merged 14 commits into from
Oct 3, 2024

Conversation

mla2001
Copy link
Contributor

@mla2001 mla2001 commented Oct 2, 2024

Closes #4

@javihern98 javihern98 self-requested a review October 2, 2024 15:37
Copy link
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall code looks good, just slight changes are needed

src/vtlengine/Operators/Time.py Outdated Show resolved Hide resolved
src/vtlengine/Exceptions/messages.py Show resolved Hide resolved
@mla2001 mla2001 requested a review from javihern98 October 3, 2024 08:33
Copy link
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now!

@javihern98 javihern98 merged commit aac7d7f into main Oct 3, 2024
11 checks passed
@javihern98 javihern98 deleted the 2-Improve_time_operators_performance branch October 3, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve time operators performance
2 participants