Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MBEDTLS_MD_CAN_SHA1 with PSA_WANT_ALG_SHA_1 #9540

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Replace MBEDTLS_MD_CAN_SHA1 with PSA_WANT_ALG_SHA_1 #9540

merged 1 commit into from
Sep 5, 2024

Conversation

eleuzi01
Copy link
Contributor

@eleuzi01 eleuzi01 commented Sep 4, 2024

Description

Resolves #9539

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog not required, internal changes
  • development PR provided
  • framework PR not required
  • 3.6 PR not required, needed for 4.0
  • 2.28 PR not required, needed for 4.0
  • tests not required

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01
Replace MBEDTLS_MD_CAN_SHA1 with PSA_WANT_ALG_SHA_1
9fc5be0 
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
@eleuzi01 eleuzi01 added enhancement component-crypto Crypto primitives and low-level interfaces size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Sep 4, 2024
@eleuzi01 eleuzi01 mentioned this pull request Sep 4, 2024
Merged
6 tasks
ronald-cron-arm
ronald-cron-arm approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Sep 5, 2024
gabor-mezei-arm
gabor-mezei-arm approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@gabor-mezei-arm gabor-mezei-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabor-mezei-arm gabor-mezei-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Sep 5, 2024
@davidhorstmann-arm davidhorstmann-arm added this pull request to the merge queue Sep 5, 2024
Merged via the queue into Mbed-TLS:development with commit 924c1a3 Sep 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronald-cron-arm ronald-cron-arm ronald-cron-arm approved these changes

@gabor-mezei-arm gabor-mezei-arm gabor-mezei-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces enhancement priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace MBEDTLS_MD_CAN_SHA1 with its PSA_WANT counterpart
4 participants
@eleuzi01 @ronald-cron-arm @gabor-mezei-arm @davidhorstmann-arm