-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS 1.3: Resumption and early data compatibility tests #8914
TLS 1.3: Resumption and early data compatibility tests #8914
Conversation
…ting Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Eventually we do not support early data with external PSK thus no point to do a positive test on that basis. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Move m->m resumption tests just before resumption and early data tests against GnuTLS and OpenSSL. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
ed3916c
to
dd2dc15
Compare
Is the CI failure something to worry about? It's on the Internal CI only.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as long as the CI failure is unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding negative testing for max_early_data_size and ALPN with GnuTLS or is it out of scope? otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The test that failed is a DTLS test "Session resume using tickets, DTLS: openssl server", that has no relation with the changes in this PR. It passes on the open CI thus I do not think we have to worry about that. |
That would involve setting configuration for the first handshake and then changing them when we resume. That's not really in the scope of ssl-opt.sh to me (and we have done that in test_suite_ssl). |
0edef1c
Description
Fix #6362
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")