-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check ALPN when receiving early data #8911
Check ALPN when receiving early data #8911
Conversation
a500ef9
to
99c6492
Compare
This has the "needs-preceding-pr" label but no mention of what it depends on. Also it has a merge conflict. |
99c6492
to
6b0ee52
Compare
6b0ee52
to
22ac899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks almost good to me. The change log needs to be improved though (I've proposed something). Otherwise a few other suggestions for improvement.
22ac899
to
9b51e8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. We need to backport the commit "Fix bug in ALPN negotiating".
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one comment, not a blocker. And agreed, we need a backport of the bug fix
The merge-base changed after approval.
Signed-off-by: Waleed Elmelegy <waleed.elmelegy@arm.com>
Signed-off-by: Waleed Elmelegy <waleed.elmelegy@arm.com>
9b51e8e
to
4dfb0e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done the rebase and ended up with the same tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks
a457633
Description
Check if new session has the same ALPN as old session when receiving early data and if not reject early data.
fix #6355
Depends on #8858
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")