Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS: remove RSA signature algorithms in suite B profile #8554

Merged
merged 5 commits into from
Jan 12, 2024
Merged

TLS: remove RSA signature algorithms in suite B profile #8554

merged 5 commits into from
Jan 12, 2024

Conversation

yanrayw
Copy link

@yanrayw yanrayw commented Nov 22, 2023 •
edited
Loading

Description

Fix #8221

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog provided
  • backport not required (no such issue in mbedtls-2.28, it's introduced when developing features in TLS1.3)
  • tests not required

Yanray Wang added 5 commits November 22, 2023 16:28
ssl_tls: remove RSA sig-algs in ssl_preset_suiteb_sig_algs
b1f6016 
Signed-off-by: Yanray Wang <yanray.wang@arm.com>
ssl_tls: remove RSA sig-algs in ssl_tls12_preset_suiteb_sig_algs
69ceb39 
Signed-off-by: Yanray Wang <yanray.wang@arm.com>
tls13: fix a wrong RFC reference section
55933a3 
Signed-off-by: Yanray Wang <yanray.wang@arm.com>
ssl_tls: improve readability in ssl_*_preset_*_sig_algs
1136fad 
- fix wrong comment in #endif
- no semantics changes

Signed-off-by: Yanray Wang <yanray.wang@arm.com>
TLS Suite B fix: add ChangeLog entry
d8c899c 
Signed-off-by: Yanray Wang <yanray.wang@arm.com>
@yanrayw yanrayw added bug needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Nov 22, 2023
@yanrayw yanrayw removed the needs-ci Needs to pass CI tests label Dec 5, 2023
mpg
mpg approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

tom-cosgrove-arm
tom-cosgrove-arm approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jan 11, 2024
@tom-cosgrove-arm tom-cosgrove-arm added this pull request to the merge queue Jan 12, 2024
Merged via the queue into Mbed-TLS:development with commit bc5d916 Jan 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpg mpg mpg approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS "suite B" profile should not include RSA
3 participants
@yanrayw @mpg @tom-cosgrove-arm