Add python version check #8504
Open
Add python version check #8504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have requested python 3.6 at https://mbed-tls.readthedocs.io/en/latest/getting_started/building/ But the CI scripts still check python with 3.5 Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>
yuhaoth
added
needs-review
gilles-peskine-arm
requested changes
Nov 9, 2023
| support_check_python_files () { | ||
| python3 - <<EOF | ||
| import sys | ||
| if sys.version_info.major >= 3 and sys.version_info.minor >= 6: |
There was a problem hiding this comment.
We still have Python 3.5 on our CI. Until we upgrade, we need our Python scripts to work with Python 3.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have requested python 3.6 at https://mbed-tls.readthedocs.io/en/latest/getting_started/building/ . So we must disable CI test for older python
PR checklist
provided, ornot required( It is internal test script change)provided, ornot required( test scripts)