-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for arm64_32 (aka ILP32) on Clang #7808
Merged
daverodgman
merged 15 commits into
Mbed-TLS:development
from
daverodgman:fix-ct-compile-warning
Jun 27, 2023
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b19f584
Fix for arm64_32 (aka ILP32) on Clang
daverodgman 04cb9ac
Fix for arm64_32 (aka ILP32) on Clang (attempt 2)
daverodgman b67db91
Separate ILP32 and normal-aarch64 code paths
daverodgman 517e891
Changelog
daverodgman 85842b8
Be strict about pointer size in mbedtls_get_unaligned_volatile_uint32
daverodgman 63e89b4
Use UINTPTR_MAX not SIZE_MAX
daverodgman 140fa15
Improve changelog
daverodgman c54f25e
code style
daverodgman 0400ae2
Fix pointer constraint in bn_mul.h
daverodgman b5b6939
Remove redundant checks in constant_time.c
daverodgman 5b5dd01
code style
daverodgman e6c9996
Work around updating pointers from ILP32
daverodgman 4e5c63d
Improve documentation in bn_mul.h
daverodgman 9e868be
Fix clang warning from -Wasm-operand-widths
daverodgman 8c5fae2
Add explanatory comment
daverodgman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Bugfix | ||
* Fix a compile failure in the constant_time module when building | ||
for watchos (i.e. for Aarch64 ILP32). Reported by Paulo Coutinho | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minor, perhaps updating just for that: watchos is not really material here, what's material is arm64_32. Suggested wording: “when building for arm64_32, e.g. for watchOS”. |
||
in #7787. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, not worth updating just for that: