Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: no newline when debug msg over DEBUG_BUF_SIZE - backport 2.28 #7608

Merged
merged 8 commits into from
May 17, 2023
Merged

Fix: no newline when debug msg over DEBUG_BUF_SIZE - backport 2.28 #7608

merged 8 commits into from
May 17, 2023

Conversation

daverodgman
Copy link
Contributor

@daverodgman daverodgman commented May 16, 2023 •
edited by davidhorstmann-arm
Loading

Description

Trivial backport of #7607

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

valord577 and others added 8 commits May 16, 2023 16:47
@valord577 @daverodgman
Fix: no newline when debug msg over DEBUG_BUF_SIZE
afbaac2 
Signed-off-by: valord577 <valord577@gmail.com>
@daverodgman
Update library/debug.c
40fe1cd 
Fix trailing white-space

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@valord577 @daverodgman
send debug msg if contains '\n'
e362392 
Signed-off-by: valord577 <valord577@gmail.com>
@valord577 @daverodgman
make code readable and change var name
06b0bb5 
Signed-off-by: valord577 <valord577@gmail.com>
@valord577 @daverodgman
code style
de6ea98 
Signed-off-by: valord577 <valord577@gmail.com>
@valord577 @daverodgman
simplify code
0d87d90 
Signed-off-by: valord577 <valord577@gmail.com>
@daverodgman
Document minimum size for DEBUG_BUF_SIZE
0019178 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman
Make use of MBEDTLS_STATIC_ASSERT
bd77182 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman daverodgman changed the base branch from development to mbedtls-2.28 May 16, 2023 15:49
@daverodgman daverodgman added bug needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review single-reviewer This PR qualifies for having only one reviewer priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) component-platform Portability layer and build scripts labels May 16, 2023
davidhorstmann-arm
davidhorstmann-arm approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidhorstmann-arm davidhorstmann-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels May 16, 2023
@davidhorstmann-arm davidhorstmann-arm mentioned this pull request May 17, 2023
Merged
3 tasks
@davidhorstmann-arm davidhorstmann-arm removed the needs-ci Needs to pass CI tests label May 17, 2023
@daverodgman daverodgman merged commit 247e6f0 into Mbed-TLS:mbedtls-2.28 May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-platform Portability layer and build scripts priority-medium Medium priority - this can be reviewed as time permits single-reviewer This PR qualifies for having only one reviewer size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daverodgman @davidhorstmann-arm @valord577