Fix IAR enum conversion warnings when using mbedtls_md_type_t and mbedtls_cipher_type_t #7543
+26
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saketh Sunkishala <Saketh.Sunkishala@silabs.com>
Signed-off-by: Saketh Sunkishala <Saketh.Sunkishala@silabs.com>
tom-cosgrove-arm
changed the title
gilles-peskine-arm
requested changes
May 3, 2023
| @@ -379,7 +379,7 @@ typedef struct mbedtls_cipher_context_t { | |||
| * \return A statically-allocated array of cipher identifiers | |||
| * of type cipher_type_t. The last entry is zero. | |||
| */ | |||
| const int *mbedtls_cipher_list(void); | |||
| const mbedtls_cipher_type_t *mbedtls_cipher_list(void); | |||
There was a problem hiding this comment.
This is an incompatible change which we can't accept in a minor release. It breaks application code like
const int *array = mbedtls_cipher_list();
gilles-peskine-arm
added
needs-work
component-crypto
|
We are now converting older PRs to draft PRs where the following conditions are met: They have not been updated in the last 3 months, and they need more than non-trivial work to complete. |
tom-daubney-arm
added
the
historical-reviewed
|
@AgathiyanB are you aware of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use mbedtls_md_type_t and mbedtls_cipher_type_t data type when required, to avoid enum conversions. Warnings seen with IAR.
Gatekeeper checklist