Support challenge password attribute in CSR #7444
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisj
force-pushed
the
topic/support_csr_challenge_password
branch
from
de465b7 to
4192491
Compare
yuhaoth
added
enhancement
needs-review
Contributor
|
This PR got some code style fail . Please fix that. |
Useful as an extra form of authentication in certificate
enrollment/renewal using SCEP [1] or EST [2].
Specified in RFC 2985 [3] as
challengePassword ATTRIBUTE ::= {
WITH SYNTAX DirectoryString {pkcs-9-ub-challengePassword}
EQUALITY MATCHING RULE caseExactMatch
SINGLE VALUE TRUE
ID pkcs-9-at-challengePassword
}
Use mbedtls_x509write_csr_set_challenge_password function to set the
challenge password in mbedtls_x509write_csr object, either as (text)
printable (preferred), or UTF-8 string.
resolves Mbed-TLS#4886
1. https://www.rfc-editor.org/rfc/rfc8894.html#name-challengepassword-shared-se
2. https://www.rfc-editor.org/rfc/rfc7030#section-4.5
3. https://www.rfc-editor.org/rfc/rfc2985#section-5.4
Signed-off-by: Tijs Van Buggenhout <tijs.van.buggenhout@axsguard.com>
tisj
force-pushed
the
topic/support_csr_challenge_password
branch
from
4192491 to
8b9825e
Compare
Author
|
@yuhaoth thx, done Anything I should do about the ABI errors? |
Contributor
This is fine. The changes here are an ABI break but not an API break, which is OK for the 3.x branch. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful as an extra form of authentication in certificate enrollment/renewal using SCEP [1] or EST [2].
Specified in RFC 2985 [3] as
Use mbedtls_x509write_csr_set_challenge_password function to set the challenge password in mbedtls_x509write_csr object, either as (text) printable (preferred), or UTF-8 string.
resolves #4886
Description
Please write a few sentences describing the overall goals of the pull request's commits.
Gatekeeper checklist
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.