-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bignum: Extract secp384r1 fast reduction from the prototype #7222
Merged
yanesca
merged 7 commits into
Mbed-TLS:development
from
minosgalanakis:bignum/6851_extract_Secp384r1_fast_reduction
Mar 27, 2023
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6fb105f
ecp_curves: Ported prototypes
minosgalanakis 619385d
test_suite_ecp: Added ecp_mod_p384_raw() test case.
minosgalanakis f359c91
ecp test generator: Added EcpPp384R1Raw().
minosgalanakis 37f4cb6
ecp_curves: Minor rework for p384
minosgalanakis 4af90bb
EcpP384R1Raw: Added test case for 2nd round of carry reduction.
minosgalanakis 68d64a1
ecp_curves: Re-introduced `mbedtls_ecp_fix_negative()`
minosgalanakis f9fca53
ecp_curves: Updated ecp_mod_p384_raw documentation
minosgalanakis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeating
bits / 8 / sizeof(mbedtls_mpi_uint)
- can we have a variable for this please?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is not new, it was just moved further down the code. I would rather not modify it since it falls out of the scope of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay