[Backport 2.28] Use config.py as a module in depends.py #7104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
Requested config option can be either boolean or a string. Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
As suggested by gilles-peskine-arm. Co-authored-by: Gilles Peskine <gilles.peskine@arm.com> Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
As suggested by gilles-peskine-arm. Co-authored-by: Gilles Peskine <gilles.peskine@arm.com> Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
AndrzejKurek
added
needs-review
gilles-peskine-arm
previously approved these changes
Feb 15, 2023
| """Set/unset a configuration option, optionally specifying a value. | ||
| value can be either True/False (set/unset config option), or a string, | ||
| which will make a symbol defined with a certain value.""" | ||
| if not option_exists(conf, option): |
There was a problem hiding this comment.
depends.py in 2.28 currently relies on being able to unset an option that doesn't exist.
depends.py: Symbol MBEDTLS_SHA256_USE_A64_CRYPTO_IF_PRESENT was not found in include/mbedtls/config.h
I think it would be best to remove the A64 symbols from the 2.28 version of the file.
There was a problem hiding this comment.
Another good side of reusing well prepared scripts :)
gilles-peskine-arm
added
needs-work
and removed
needs-review
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>
AndrzejKurek
added
needs-review
gilles-peskine-arm
approved these changes
Feb 28, 2023
mprse
approved these changes
Mar 1, 2023
mprse
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #6493.
depends.py now uses config.py to get the available configuration options as well as manipulate the config file.
Straightforward backport, the only conflicts were due to the surrounding code using
config.hinstead ofmbedtls_config.h.