DRAFT Pkcs7 nondetached #7054
Draft
DRAFT Pkcs7 nondetached #7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise invalid data could be accepted. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
No change in behavior Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
This adds more code, but the newer code is easier to understand. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
There must not be any. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
No change in behavior. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
MBEDTLS_ERR_BAD_INPUT_DATA indicates a bug in the caller, such as passing NULL to an interface that doesn't accept it. It should not be used for an unsupported type of content. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
This makes the SignedData available to callers. Previously, it was ignored. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
A CMS signature can have internal data. Provide a function for verifying this data, and check that it is absent when verifying detached signatures. Signed-off-by: Demi Marie Obenour <demiobenour@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture @DemiMarie 's work on PKCS 7 non-detached signatures from #6672 in a standalone PR