-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve warnings for DES/3DES #7022
Improve warnings for DES/3DES #7022
Conversation
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add warnings in cipher.h
. Other than that LGTM.
@@ -3,7 +3,7 @@ | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also state this warning for enum constants or the like that indicate DES in high-level APIs. There are already warnings for PSA_KEY_TYPE_DES
, but not for the DES enum constants in cipher.h
. Please add warnings (at least a short statement, not necessarily a full-fledged \warnings
) in cipher.h
.
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (fdbfaaf, not the previous partial push)
@tom-cosgrove-arm So are you ok with merging as is? If so please approve the pull request. |
Ensure DES warnings also refer to 3DES