Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve warnings for DES/3DES #7022

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Improve warnings for DES/3DES #7022

merged 3 commits into from
Feb 3, 2023

Conversation

daverodgman
Copy link
Contributor

@daverodgman daverodgman commented Feb 2, 2023 •
edited
Loading

Ensure DES warnings also refer to 3DES

@daverodgman
Improve warnings for DES/3DES
c04515b 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
@daverodgman daverodgman mentioned this pull request Feb 2, 2023
Merged
3 tasks
@daverodgman daverodgman added bug needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests component-docs Docs / website issues filed here for tracking needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Feb 2, 2023
@daverodgman daverodgman added the single-reviewer This PR qualifies for having only one reviewer label Feb 2, 2023
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Feb 2, 2023
Open
gilles-peskine-arm
gilles-peskine-arm requested changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add warnings in cipher.h. Other than that LGTM.

include/mbedtls/des.h
@@ -3,7 +3,7 @@
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also state this warning for enum constants or the like that indicate DES in high-level APIs. There are already warnings for PSA_KEY_TYPE_DES, but not for the DES enum constants in cipher.h. Please add warnings (at least a short statement, not necessarily a full-fledged \warnings) in cipher.h.

@daverodgman
Update warnings in cipher.h
23caf02 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
gilles-peskine-arm
gilles-peskine-arm previously approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daverodgman
Additional warnings in cipher.h
fdbfaaf 
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
gilles-peskine-arm
gilles-peskine-arm approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (fdbfaaf, not the previous partial push)

@daverodgman daverodgman added the approved Design and code approved - may be waiting for CI or backports label Feb 2, 2023
@tom-cosgrove-arm tom-cosgrove-arm removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Feb 2, 2023
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, and removed approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests labels Feb 3, 2023
@gilles-peskine-arm
Copy link
Contributor

@tom-cosgrove-arm So are you ok with merging as is? If so please approve the pull request.

@tom-cosgrove-arm tom-cosgrove-arm added the approved Design and code approved - may be waiting for CI or backports label Feb 3, 2023
@tom-cosgrove-arm tom-cosgrove-arm removed the needs-review Every commit must be reviewed by at least two team members, label Feb 3, 2023
@gilles-peskine-arm gilles-peskine-arm merged commit 10ada35 into Mbed-TLS:development Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-docs Docs / website issues filed here for tracking priority-high High priority - will be reviewed soon single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daverodgman @gilles-peskine-arm @tom-cosgrove-arm