Introduce psa/crypto_driver.h #5464
Draft
+193
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drivers need to have access to some declarations. Specify that they are made available through the header file "psa/crypto_driver.h". Specify that the following API elements are available to drivers: numerical types and macros, key attributes. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Create the header file. Make it declare macros and types. Attribute accessor functions and some Mbed TLS extensions are missing. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Check that a source file that includes the header builds correctly. Check the presence of a couple of identifiers. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
We keep forgetting to register new test suites in tests/CMakeLists.txt. To fix this problem once and for all, remove the need for manual registration. The following test suites were missing: test_suite_cipher.aria test_suite_psa_crypto_driver_wrappers test_suite_psa_crypto_generate_key.generated Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
enhancement
needs-work
component-psa
daverodgman
added
the
priority-medium
febdoctor
pushed a commit
to silexinsight/mbedtls
that referenced
this pull request
Jun 1, 2022
For PSA crypto drivers, pull request Mbed-TLS#5464 will add PSA_DRIVER_GET_ENTROPY_BLOCK in a header in include/psa. To be able to build and test, it's temporarily added in the internal header file for PSA driver wrapper.
febdoctor
pushed a commit
to silexinsight/mbedtls
that referenced
this pull request
Jun 1, 2022
For PSA crypto drivers, pull request Mbed-TLS#5464 will add PSA_DRIVER_GET_ENTROPY_BLOCK in a header in include/psa. To be able to build and test, it's temporarily added in the internal header file for PSA driver wrapper. Signed-off-by: François Beerten <francois.beerten@silexinsight.com> Signed-off-by: Francois Beerten <fbeerten.git@b10eng.com>
febdoctor
pushed a commit
to silexinsight/mbedtls
that referenced
this pull request
Jun 1, 2022
For PSA crypto drivers, pull request Mbed-TLS#5464 will add PSA_DRIVER_GET_ENTROPY_BLOCK in a header in include/psa. To be able to build and test, it's temporarily added in the internal header file for PSA driver wrapper. Signed-off-by: François Beerten <francois.beerten@silexinsight.com> Signed-off-by: Francois Beerten <fbeerten.git@b10eng.com>
febdoctor
pushed a commit
to silexinsight/mbedtls
that referenced
this pull request
Jun 3, 2022
For PSA crypto drivers, pull request Mbed-TLS#5464 will add PSA_DRIVER_GET_ENTROPY_BLOCK in a header in include/psa. To be able to build and test, it's temporarily added in the internal header file for PSA driver wrapper. Signed-off-by: François Beerten <francois.beerten@silexinsight.com> Signed-off-by: Francois Beerten <fbeerten.git@b10eng.com>
febdoctor
pushed a commit
to silexinsight/mbedtls
that referenced
this pull request
Jun 6, 2022
For PSA crypto drivers, pull request Mbed-TLS#5464 will add PSA_DRIVER_GET_ENTROPY_BLOCK in a header in include/psa. To be able to build and test, it's temporarily added in the internal header file for PSA driver wrapper. Signed-off-by: François Beerten <francois.beerten@silexinsight.com> Signed-off-by: Francois Beerten <fbeerten.git@b10eng.com>
febdoctor
pushed a commit
to silexinsight/mbedtls
that referenced
this pull request
Jun 6, 2022
For PSA crypto drivers, pull request Mbed-TLS#5464 will add PSA_DRIVER_GET_ENTROPY_BLOCK in a header in include/psa. To be able to build and test, it's temporarily added in the internal header file for PSA driver wrapper. Signed-off-by: François Beerten <francois.beerten@silexinsight.com> Signed-off-by: Francois Beerten <fbeerten.git@b10eng.com>
febdoctor
pushed a commit
to silexinsight/mbedtls
that referenced
this pull request
Jun 6, 2022
For PSA crypto drivers, pull request Mbed-TLS#5464 will add PSA_DRIVER_GET_ENTROPY_BLOCK in a header in include/psa. To be able to build and test, it's temporarily added in the internal header file for PSA driver wrapper. Signed-off-by: François Beerten <francois.beerten@silexinsight.com> Signed-off-by: Francois Beerten <fbeerten.git@b10eng.com>
febdoctor
pushed a commit
to silexinsight/mbedtls
that referenced
this pull request
Jun 6, 2022
For PSA crypto drivers, pull request Mbed-TLS#5464 will add PSA_DRIVER_GET_ENTROPY_BLOCK in a header in include/psa. To be able to build and test, it's temporarily added in the internal header file for PSA driver wrapper. Signed-off-by: François Beerten <francois.beerten@silexinsight.com> Signed-off-by: Francois Beerten <fbeerten.git@b10eng.com>
febdoctor
pushed a commit
to silexinsight/mbedtls
that referenced
this pull request
Aug 2, 2022
For PSA crypto drivers, pull request Mbed-TLS#5464 will add PSA_DRIVER_GET_ENTROPY_BLOCK in a header in include/psa. To be able to build and test, it's temporarily added in the internal header file for PSA driver wrapper. Signed-off-by: François Beerten <francois.beerten@silexinsight.com> Signed-off-by: Francois Beerten <fbeerten.git@b10eng.com>
febdoctor
pushed a commit
to silexinsight/mbedtls
that referenced
this pull request
Aug 3, 2022
For PSA crypto drivers, pull request Mbed-TLS#5464 will add PSA_DRIVER_GET_ENTROPY_BLOCK in a header in include/psa. To be able to build and test, it's temporarily added in the internal header file for PSA driver wrapper. Signed-off-by: François Beerten <francois.beerten@silexinsight.com> Signed-off-by: Francois Beerten <fbeerten.git@b10eng.com>
febdoctor
pushed a commit
to silexinsight/mbedtls
that referenced
this pull request
Aug 4, 2022
For PSA crypto drivers, pull request Mbed-TLS#5464 will add PSA_DRIVER_GET_ENTROPY_BLOCK in a header in include/psa. To be able to build and test, it's temporarily added in the internal header file for PSA driver wrapper. Signed-off-by: François Beerten <francois.beerten@silexinsight.com> Signed-off-by: Francois Beerten <fbeerten.git@b10eng.com>
|
As part of our review of historical PRs we have made the decision to convert older PRs that have not been updated in 3 months into drafts until they are worked on again. |
tom-daubney-arm
added
the
historical-reviewed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be a header file that declares the parts of the PSA Crypto API that's meant to be accessible to drivers, as well as some identifiers that are for drivers only. Add one to the driver specification draft, and create it in Mbed TLS.
Status: the header file is incomplete, it's still missing at least key attribute functions.
There is a new test suite. I deliberately didn't add it to
tests/CMakeLists.txt. It will be handled via #5463.