[WIP] Makefile dependency generation #5433
Conversation
tests/scripts/all.sh
Outdated
| @@ -590,7 +590,7 @@ pre_setup_keep_going () { | |||
| case "$1" in | |||
| "msg "*) false;; | |||
| "cd "*) false;; | |||
| *make*[\ /]tests*) false;; # make tests, make CFLAGS=-I../tests, ... | |||
| *make*[\ /]tests*) false;; # make tests, make CFLAGS=-Itests, ... | |||
There was a problem hiding this comment.
I'm afraid that if we need to make this change in our scripts, it likely means some users will have to make similar changes, and so this breaks backward compatibility.
There was a problem hiding this comment.
In principle, I like that everything is done from the toplevel directory. I'm just worried that we can't do it.
I think we can preserve backward compatibility at the cost of adding a lot of cd commands.
There was a problem hiding this comment.
Hmmm, Ok. I think I know how I could emulate this behaviour, If we want to keep maximum backwards compatibility.
There was a problem hiding this comment.
On second thought, the current behaviour of our Makefiles with regards to CFLAGS, etc. is very unintuitive, if you use relative paths.
CFLAGS=-Ifoo means library/foo for the files in the library and 3rdparty/everest directories, while it means programs/foo in the programs directory, tests/foo in the tests directory and tests/fuzz/foo in the tests/fuzz/foo directory.
It would be much more sane for everything to be relative to the toplevel directory. I would expect that users have to work around this already by using absolute paths if they build anything outside the files under library.
There was a problem hiding this comment.
Granted, most users probably do only care about things under library
There was a problem hiding this comment.
I've added the cd commands needed to emulate the old behaviour.
bensze01
force-pushed
the
make_dependency_generation
branch
from
28e5f84
to
c0d1a16
Compare
bensze01
force-pushed
the
make_dependency_generation
branch
8 times, most recently
from
a4200a1
to
9c25d29
Compare
bensze01
force-pushed
the
make_dependency_generation
branch
from
39c313b
to
37ea7ac
Compare
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
The value of MAKEFILE_LIST will change after the next include, so evaluate the expression immediately. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
force-pushed
the
make_dependency_generation
branch
2 times, most recently
from
e6eb052
to
4132968
Compare
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
force-pushed
the
make_dependency_generation
branch
from
4132968
to
affe972
Compare
bensze01
force-pushed
the
make_dependency_generation
branch
2 times, most recently
from
c09d335
to
3fa972f
Compare
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
force-pushed
the
make_dependency_generation
branch
from
3fa972f
to
6b52f9b
Compare
tom-daubney-arm
added
the
historical-reviewed
|
We are now converting older PRs to draft PRs where the following conditions are met: They have not been updated in the last 3 months, and they need more than non-trivial work to complete. |
Status
WIP