Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typos and spelling mistakes #2371

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Fix minor typos and spelling mistakes #2371

merged 1 commit into from
Jan 31, 2019

Conversation

MisterDA
Copy link
Contributor

This PR is the result of automatic misspelling detection.
It does not consider different US/UK spellings.
It fixes #2370.

@irwir
Copy link
Contributor

irwir commented Jan 23, 2019

https://github.com/ARMmbed/mbedtls/blob/742f4a9f42db4caf71564fe052d84cf194c22356/include/mbedtls/config.h#L1707

This a applicable looks suspicious. Should it be fixed too?

@MisterDA
Copy link
Contributor Author

s/a applicable/applicable/g :)
For the record, this was done with https://github.com/client9/misspell.

@RonEld RonEld added bug CLA valid needs-review Every commit must be reviewed by at least two team members, labels Jan 28, 2019
Copy link
Contributor

@simonbutcher simonbutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Looks good to me. Some of these fixes merit backporting, although some are too minor, so we will need the PR backported even if it doesn't include every fix.

@@ -111,14 +111,14 @@ int mbedtls_ssl_ticket_setup( mbedtls_ssl_ticket_context *ctx,
/**
* \brief Implementation of the ticket write callback
*
* \note See \c mbedlts_ssl_ticket_write_t for description
* \note See \c mbedtls_ssl_ticket_write_t for description
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix merits backporting.

*/
mbedtls_ssl_ticket_write_t mbedtls_ssl_ticket_write;

/**
* \brief Implementation of the ticket parse callback
*
* \note See \c mbedlts_ssl_ticket_parse_t for description
* \note See \c mbedtls_ssl_ticket_parse_t for description
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix merits backporting.

@simonbutcher simonbutcher added the needs-backports Backports are missing or are pending review and approval. label Jan 29, 2019
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patater Patater added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jan 30, 2019
@Patater Patater merged commit 36e89b5 into Mbed-TLS:development Jan 31, 2019
Patater added a commit that referenced this pull request Jan 31, 2019
@MisterDA MisterDA deleted the misspell branch January 31, 2019 12:49
@Patater
Copy link
Contributor

Patater commented Feb 1, 2019

Merged to development without backports because of how quickly these sorts of PRs go stale. This still needs some changes backported to mbedtls-2.16 and mbedtls-2.7.

@simonbutcher simonbutcher removed the needs-backports Backports are missing or are pending review and approval. label Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor typos in documentation
5 participants