Backport 2.7: Change file scoping of test helper functions #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependent on configured options, not all of the helper functions were being used, which was leading to warning of unused functions with Clang. To avoid any complex compile time options, or adding more logic to generate_test_code.py to screen out unused functions, those functions which were provoking the warning were changed to remove static, remove them from file scope, and expose them to the linker.
tests/Makefile had some unused warnings disabled unnecessarily, which test-ref-configs.pl was turning back on. We don't need to disable these warnings so I'm turning them back on.
4 tasks
simonbutcher
requested review from
mpg,
RonEld and
Patater
and removed request for
RonEld
simonbutcher
added
bug
mbed TLS team
needs-review
|
I've reflected the fix to the ChangeLog I made in #2053. @Patater / @mpg / @gilles-peskine-arm - Can at least two of you please re-review? Thanks. |
Patater
approved these changes
Apr 18, 2019
| @@ -3,7 +3,7 @@ | |||
| # To compile with PKCS11: add "-lpkcs11-helper" to LDFLAGS | |||
|
|
|||
| CFLAGS ?= -O2 | |||
| WARNING_CFLAGS ?= -Wall -W -Wdeclaration-after-statement -Wno-unused-function -Wno-unused-value | |||
| WARNING_CFLAGS ?= -Wall -W -Wdeclaration-after-statement -Wunused | |||
There was a problem hiding this comment.
Minor: Probably don't need -Wunused here, since -Wall enables lots of -Wunused-* warnings.
mpg
approved these changes
Apr 19, 2019
mpg
removed
the
needs-review
|
Note: the only failure in Jenkins on the PR head is the know-flaky timing test suite (on BSD) which hadn't been fixed yet when this PR was created. The job didn't run on the merge result due to the conflict in the ChangeLog. |
Patater
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #2053.
Dependent on configured options, not all of the helper functions were being used, which was leading to warning of unused functions with Clang.
To avoid any complex compile time options, or adding more logic to
generate_test_code.pyto screen out unused functions, those functions which were provoking the warning were changed to remove static, remove them from file scope, and expose them to the linker.Fixes #2051.
Status
READY
Todos