-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update log level for mbedtls_ssl_check_record and PSA-based ECDH computation #10496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
Signed-off-by: Juha-Pekka <juha-pekka.kesonen@nordicsemi.no>
Signed-off-by: Juha-Pekka <juha-pekka.kesonen@nordicsemi.no>
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for submitting a PR!
The same logs exist in 3.6, so can you please make a backport to the mbedtls-3.6 branch?
I don't think this needs a changelog entry: it's technically a bug, but a very minor one. But I wouldn't object to a changelog entry if someone wants one.
davidhorstmann-arm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description
I noticed some logs that are logged as errors that are not actually indicative of serious issues.
I also asked about it on the discord server.
According to the debug.h, informational logs should be of log level 3.
Our implementation translates mbedlts logs from 1 to WARN.
The following logs are set at level 1, but they do not signify that an error has occurred.
PR checklist
Notes for the submitter
Help make review efficient: