Skip to content

Conversation

@JuhaPekkaa
Copy link

@JuhaPekkaa JuhaPekkaa commented Nov 5, 2025

Description

I noticed some logs that are logged as errors that are not actually indicative of serious issues.
I also asked about it on the discord server.

According to the debug.h, informational logs should be of log level 3.

Our implementation translates mbedlts logs from 1 to WARN.
The following logs are set at level 1, but they do not signify that an error has occurred.

WARN [mbedtls ssl_msg.c:366] <= mbedtls_ssl_check_record
WARN [mbedtls ssl_msg.c:324] => mbedtls_ssl_check_record 

WARN  [mbedtls ssl_tls12_client.c:2307] Perform PSA-based ECDH computation.
WARN  [mbedtls ssl_tls12_server.c:2686] Perform PSA-based ECDH computation.

PR checklist

Notes for the submitter

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

Signed-off-by: Juha-Pekka <juha-pekka.kesonen@nordicsemi.no>
Signed-off-by: Juha-Pekka <juha-pekka.kesonen@nordicsemi.no>
@JuhaPekkaa JuhaPekkaa marked this pull request as ready for review November 5, 2025 12:39
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for submitting a PR!

The same logs exist in 3.6, so can you please make a backport to the mbedtls-3.6 branch?

I don't think this needs a changelog entry: it's technically a bug, but a very minor one. But I wouldn't object to a changelog entry if someone wants one.

@gilles-peskine-arm gilles-peskine-arm added enhancement needs-review Every commit must be reviewed by at least two team members, needs-backports Backports are missing or are pending review and approval. component-tls needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Nov 5, 2025
@gilles-peskine-arm gilles-peskine-arm moved this to Scoped in Community Nov 5, 2025
@davidhorstmann-arm davidhorstmann-arm moved this from Scoped to Next 3 items in Community Nov 6, 2025
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-project-automation github-project-automation bot moved this from In Development to Has Approval in Non-roadmap pull requests Nov 6, 2025
@davidhorstmann-arm davidhorstmann-arm added this pull request to the merge queue Nov 6, 2025
@davidhorstmann-arm davidhorstmann-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-backports Backports are missing or are pending review and approval. needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review needs-ci Needs to pass CI tests labels Nov 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Design and code approved - may be waiting for CI or backports component-tls enhancement priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)

Projects

Status: Next 3 items
Status: Has Approval

Development

Successfully merging this pull request may close these issues.

3 participants