-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support armv8 crypto extensions for AES and GCM #5387
Comments
We had a discussion about this and agreed to:
|
Do we plan to add Arm64 CI test? I think it should be added, this issue can not be covered for time being. |
Yes, I think we should add testing to the CI at least with qemu. However, if it doesn't make things too difficult, I suggest add the feature first (validate it with manual testing) and add the tests to the CI only afterwards. |
Add list of sub-tasks.
|
Known issues when development.
|
What's the problem? |
Reproduce the issue on Arm64 host with below scripts.
It reports
|
it is implemented at e9a7159 |
Ah, ok.
Ideally cmake would automatically do the right thing, but we haven't done anything to make it work, and I don't know how hard it is. This is documented in |
But my host is arm64. I build it on ARM64 host. |
Oh? Then I don't understand the error. All that's required for |
That equal |
I see. None of this should be a problem in the |
|
I'd like reduce the scope of this issue. I won't resolve the issues raised at #5387 (comment). and I will add it as known issue. Below points need confirm.
I will create new issues to cover left topics before Chinese New Year. |
Update , some sub-tasks are moved to other issues
|
We should not check compiler flags in
|
Got it . I just split the tasks. And I will proposal my solution on #5758. Let's continue the discussion in it. |
Regarding #6895 (comment), I agree with @yuhaoth and I think that SHA3 extension is specific enough to make an exception for it. I think we should constrain the SHA3 extension to the SHA module. If we can't do it from the build system, then we should turn it on in the source file. @gilles-peskine-arm @tom-cosgrove-arm what do you think? |
@yanesca I'm sorry, I have no idea what exception you're referring to. I've posted my thoughts on #7004 (review) and #6895 (comment). |
I have added Arm64 travis ci test in #6895 . for qemu, I will try add a guide firstly. |
Raised #7141 for tracking hardware only config options and collected the AES armv8 related issues in an epic: |
Reopening as GCM support is still need: #6918 |
The goal of this task is to allow Mbed TLS to use ISA extensions for AES and GCM on armv8 platforms.
A work in progress from 2018 is in #1173 and #1424 (https://github.com/ARMmbed/mbedtls/tree/archive/armv8_crypto_extensions).
The text was updated successfully, but these errors were encountered: