CI script changes needed for the New CI #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensze01
added
enhancement
bensze01
force-pushed
the
dev/bensze01/openci-testing
branch
7 times, most recently
from
81d82b5 to
e1e1777
Compare
bensze01
force-pushed
the
dev/bensze01/openci-testing
branch
from
e1e1777 to
8d1aab7
Compare
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
ECRs are not used on the current Open CI, nor is the value of docker_ecr used in the Open CI codepaths. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Use the full URL instead of the shortened form that docker also permits. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
This way we don't need to update the script if we change which CI runs the merge queues. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
The image name on the new CI corresponds to the public Dockerhub urls. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Define a new method, common.mbedtls_node() to make the transition easier. This lets us keep using the same node labels accross the CIs in most of the codebase. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Log the reason docker manifest inspect failed to help debugging. It may fail in an unexpected way, eg. if dockerhub is rate limiting us. Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
bensze01
force-pushed
the
dev/bensze01/openci-testing
branch
from
8d1aab7 to
aacb082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the changes needed to get the new CI working with the
mainbranch.(Currently it runs off of
dev/dgreen-arm/openci-testing)