PSA_WANT_xxx is only meaningful when PSA crypto is enabled #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
needs-ci
This was referenced Oct 10, 2024
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
dev/gilles-peskine-arm/generate_config_tests-require_psa
branch
from
ef7cd7b
to
239c0d8
Compare
gilles-peskine-arm
added
needs-review
yanesca
approved these changes
Oct 11, 2024
| @@ -80,7 +80,7 @@ def dependencies_of_setting(cfg: config_common.Config, | |||
| be negated by prefixing them with '!'. This is the same syntax as a | |||
| depends_on directive in test data. | |||
| """ | |||
| #pylint: disable=too-many-return-statements | |||
| #pylint: disable=too-many-branches,too-many-return-statements | |||
There was a problem hiding this comment.
Nitpick: instead of silencing the warning, we could move the TLS setting processing to a separate function.
gilles-peskine-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a missing dependency in configuration symbol test enumeration:
PSA_WANT_xxxis only meaningful when PSA crypto is enabled. This isn't needed in TF-PSA-Crypto where all crypto goes through PSA anyway, but it is relevant in 3.6 and harmless (as long as we keepMBEDTLS_PSA_CRYPTO_CLIENTat least as an internal symbol) in TF-PSA-Crypto.