Move TLS auxiliary test scripts to the framework #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
The associated config options are at the right place. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
These options have been removed now. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Move DRBG options to the "Cryptographic mechanism selection (extended API)" section. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Move MBEDTLS_SELF_TEST option to the "General and test configuration options" section as MBEDTLS_VERSION_C. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Move MBEDTLS_*_RETURN config options in the same section as MBEDTLS_CHECK_RETURN_WARNING. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Move "Cryptographic mechanism selection (extended API)" and "Data format support" just after section Cryptographic mechanism selection (PSA API)" Signed-off-by: Ronald Cron <ronald.cron@arm.com>
We will add TF-PSA-Crypto specific ones when we add support for querying version and version features in TF-PSA-Crypto. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Do not mix boolean and non boolean options though. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Re-order mbedtls_config.h sections for the order to be more aligned with the tf_psa_crypto_config.h one. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Re-organize "Mbed TLS modules" and "Module configuration options" into "X.509 feature selection" and "TLS feature selection" for better alignment with tf_psa_crypto_config.h. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Rename MBEDTLS_PSA_CRYPTO_(USER_)CONFIG_FILE to TF_PSA_CRYPTO_(USER_)CONFIG_FILE as we rename crypto_config.h to tf_psa_crypto_config.h. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Remove dependency on mbedtls_test_helpers to build the crypto test suites. mbedtls_test_helpers is TLS specific. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Move library options to the top CMakeLists.txt. That way: - we will be able to set the TF-PSA-Crypto library options according to the Mbed TLS ones. - we can define the crypto library target names in the top CMakeLists.txt and not in the library one that is dedicated to the TLS and x509 libraries now. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
Signed-off-by: Ronald Cron <ronald.cron@arm.com>
The file indicated as problematic here is the only one that was modified (removing a |
That was with git 2.34.1. With git 2.43.0 the only conflicts are I guess newer versions of git are more clever. Strategy options might matter, I haven't tried fiddling with them. |
Another difference between me and GitHub is that I was merging |
This is what I've been doing when merge conflicts appear. At one time I considered trying to make a 'rebase' feature in the script to make this easier, but it's not much more difficult to just re-run the script to regenerate the move commit. |
Signed-off-by: Gergely Korcsák <gergely.korcsak@arm.com>
eleuzi01
force-pushed
the
issue-54
branch
2 times, most recently
from
c7513b5
to
c0fe811
Compare
…t-dev Split check_test_cases.py and outcome_analysis.py
Fix driver schema json default type requirements
This commit removes #include "mbedtls/buildinfo.h" from pkcs7.c as it is not needed unlike other C modules. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
This commit replaces #include "common.h" in favour of #include "ssl_misc.h". Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
This commit replaces the include of "common.h" with "ssl_misc.h" for generated files. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
This commit removes duplicate includes for mbedtls/build_info.h where the file already includes common.h. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
…le-development Refactor duplicate common header file
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
mpg
approved these changes
Oct 16, 2024
davidhorstmann-arm
approved these changes
Oct 16, 2024
davidhorstmann-arm
added
approved
|
CI on Mbed-TLS/mbedtls#9673 and Mbed-TLS/mbedtls#9675 validates this PR so I'll merge. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #54
Development PR: Mbed-TLS/mbedtls#9673