all.sh: consistently generate files before checks, and not before builds #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
bug
gilles-peskine-arm
added
priority-medium
github-project-automation
bot
moved this to In Development
in Non-roadmap pull requests
5 tasks
Clean generated files. In Mbed TLS, `make neat`. is equivalent to `make clean; framework/scripts/make_generated_files.py --clean`. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Whether a component started with configuration-independent platform-independent generated files present or not depended on the repository and on the state of the working directory: * In TF-PSA-Crypto, we started with whatever generated files were present before invoking the script, and didn't touch them between components. * In Mbed TLS, we always started with generated files present (for subsequent components, only if they hadn't been messed up). After this change, the behavior is the same across repositories and doesn't depend on the initial state of the working directory: * `check_xxx` components start with the generated files present. This is either indifferent or necessary depending on the component. (Without generated files, some components such as `check_names` fail, while others such as `check_test_cases` miss stuff that they should check.) * Other components (`build_xxx`, `test_xxx`, etc.) start with the generated files absent. This is generally desirable so that we test that the build scripts generate them as needed. Fix Mbed-TLS#188 Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This is needed for cross-compilation because some scripts to generate generated files compile and execute a C program, and our scripts aren't set up to use a different compiler than the one we cross-compile with. Do this for all build components. It's not ideal but not harmful, and it's easier than figuring out exactly which build components are problematic. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
We need this because `library/Makefile` and `libtestdriver1_rewrite.pl` don't set things up properly in `tests/libtestdriver1/library`. The visible symptom is that when not all generated files are present, the makefile looks for `../framework/exported.make` which is not present. I have not gone down this rabbit hole to see how much effort it would be to make it work. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
all.sh-generate-only-before-checks-framework
branch
from
84fe3f0 to
876b270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the behavior of
all.shwith respect to generated files at the beginning of a component:check_xxx(where their absence can lead to a failure or silent loss of test coverage), and absent for builds and tests (where we expect the build scripts to generate them as needed).Fix #188
No change needed in consuming branches (to be confirmed by the CI), but there are a couple of things to clean up in TF-PSA-Crypto.
PR checklist
Please add the numbers (or links) of the associated pull requests for consuming branches. You can omit branches where this pull request is not needed.