module: validate request in require.resolve.paths

PR-URL: nodejs#18359 Fixes: nodejs#18352 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MayaLekova · May 8, 2018 · 51c0ff6 · 51c0ff6
1 parent 89dd70a
commit 51c0ff6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/internal/module.js b/lib/internal/module.js
@@ -27,6 +27,10 @@ function makeRequireFunction(mod) {
   require.resolve = resolve;
 
   function paths(request) {
+    if (typeof request !== 'string') {
+      throw new errors.Error('ERR_INVALID_ARG_TYPE',
+                             'request', 'string', request);
+    }
     return Module._resolveLookupPaths(request, mod, true);
   }
 

diff --git a/test/parallel/test-require-resolve.js b/test/parallel/test-require-resolve.js
@@ -47,4 +47,11 @@ const re = /^The "request" argument must be of type string\. Received type \w+$/
       code: 'ERR_INVALID_ARG_TYPE',
       message: re
     });
+
+  common.expectsError(
+    () => { require.resolve.paths(value); },
+    {
+      code: 'ERR_INVALID_ARG_TYPE',
+      message: re
+    });
 });