fix: Allow cursor_string to be null in PlaylistScores#61
Open
Unknown15082 wants to merge 1 commit intoMaxOhn:lazerfrom
Open
fix: Allow cursor_string to be null in PlaylistScores#61Unknown15082 wants to merge 1 commit intoMaxOhn:lazerfrom
Unknown15082 wants to merge 1 commit intoMaxOhn:lazerfrom
Conversation
Owner
|
Thanks for the PR! I think specifying the cursor in the let mut req = osu.playlist_scores(..).limit(..).sort(..);
if let Some(cursor) = self.cursor.as_deref() {
req = req.cursor(cursor);
}
Some(req.await) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Querying all scores in a room's playlist can return
"cursor_string": null, which causesplaylist_scoresto panic since it expected a string. To fix this, I changedcursorto be optional.Please tell me if this issue is not reproducible, or if there's anything I missed.