[pull] master from snyk:master#133
Merged
pull[bot] merged 9 commits intoMaxMood96:masterfrom Jan 12, 2022
Merged
Conversation
A previous change moved the filtering out of base image vulns (based on the existance of `dockerfileInstruction`) to be before `dockerfileInstruction` is assigned to the vulns, so all vulns were filtered out in case we used the `exclude-base-image-vulns` option. This fix moves the filtering back to where it was before, and recalculates the value of `ok`, to account for the reason it was moved in the first place.
Co-authored-by: @danlucian lucian.rosu@snyk.io Allows users with snykUnmanagedVulnDB ff in org level to visualize https://security.snyk.io/vuln/SNYK-UNMANAGED-CURL-2317584 rather than nvd url Depends on snyk/snyk-cpp-plugin#61 with feature flag <img width="470" alt="Screen Shot 2022-01-11 at 11 53 47" src="https://user-images.githubusercontent.com/40601533/148922100-369c9d87-73c2-4dcc-881c-4dffac170758.png"> without feature flag <img width="809" alt="Screen Shot 2022-01-11 at 11 53 03" src="https://user-images.githubusercontent.com/40601533/148922121-d03f6ac3-165c-4539-b8bc-f7ef5ce93ecb.png">
fix: exclude base image vulns filtering all vulns
docs: update help command help README
docs: update code command help
feat: support unmanaged snyk security url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )