[pull] master from snyk:master#127
Merged
pull[bot] merged 6 commits intoMaxMood96:masterfrom Jan 6, 2022
Merged
Conversation
The scanResult object was added to the json output where it should only have been added to calculate the the dockerfile warning string. This change removes the scanResult from the json output as it was not supposed to be exposed.
This refactor is done to not have a special case for array vs single result when formatting the results for JSON output. Note: dataToSend will now take the jsonData after formatting rather than the data before formatting. Since the formatting only changes the vulnerbilities and removes the unwanted scanResult, and since the vulnerbilities are removed from dataToSend before it is used, this change will not affect the CLI bahvior except for removing the unwanted scanResult.
Renaming the object as in IaC the logic does more than mapping the results.
Rename test fixtures used in format-test-results to align with the variable name change. This is done in a separate commit so it's clearer in git history that the files were changed and then renamed rather than deleted and created new files.
fix: Remove scanResult from json output [MAGMA-1280]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )