feat: implementing sharing files #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
awesome, thank you @kayode0x! will test it later today |
MaxAst
reviewed
Jun 4, 2024
kayode0x
changed the title
MaxAst
approved these changes
Jun 4, 2024
|
done :) |
|
Released as part of 1.8.0: https://github.com/MaxAst/expo-share-extension/releases/tag/v1.8.0 Thanks for the contribution @kayode0x 🙏 |
|
happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
kUTTypeURL.Next Steps:
kUTTypeFileURL: I am in the process of testing file uploads againstkUTTypeFileURL. This will help differentiate between general URLs and file URLs more effectively.Notes:
kUTTypeFileURL.Update:
I tested this PR on a physical device and every file still goes through kUTTypeURL, I'm not proficient in Swift but everything works fine :)