Skip to content

Commit

Permalink
add appleApplicationGroup key to expo config
Browse files Browse the repository at this point in the history
  • Loading branch information
MaxAst committed Jun 20, 2024
1 parent 25e9c93 commit 849b94b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
8 changes: 2 additions & 6 deletions examples/with-media/app.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
"resizeMode": "contain",
"backgroundColor": "#ffffff"
},
"assetBundlePatterns": [
"**/*"
],
"assetBundlePatterns": ["**/*"],
"ios": {
"supportsTablet": true,
"bundleIdentifier": "expo.modules.shareextension.withmedia"
Expand All @@ -33,9 +31,7 @@
[
"expo-font",
{
"fonts": [
"./assets/fonts/Inter-Black.otf"
]
"fonts": ["./assets/fonts/Inter-Black.otf"]
}
],
[
Expand Down
5 changes: 4 additions & 1 deletion plugin/src/withExpoConfig.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ConfigPlugin } from "@expo/config-plugins";

import {
getAppBundleIdentifier,
getAppGroup,
getShareExtensionBundleIdentifier,
getShareExtensionName,
Expand All @@ -20,6 +21,7 @@ export const withExpoConfig: ConfigPlugin = (config) => {

const extensionName = getShareExtensionName(config);
const extensionBundleIdentifier = getShareExtensionBundleIdentifier(config);
const appBundleIdentifier = getAppBundleIdentifier(config);

const iosExtensions: iOSExtensionConfig[] =
config.extra?.eas?.build?.experimental?.ios?.appExtensions;
Expand Down Expand Up @@ -57,13 +59,14 @@ export const withExpoConfig: ConfigPlugin = (config) => {
},
},
...(iosExtensions?.filter(
(extension) => extension.targetName !== extensionName,
(extension) => extension.targetName !== extensionName
) ?? []),
],
},
},
},
},
appleApplicationGroup: getAppGroup(appBundleIdentifier),
},
};
};

0 comments on commit 849b94b

Please sign in to comment.