Refactor #4
Open
Refactor #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module is tested, but not yet in use in the main code
Also disable coverage reporting for if __name__ = '__main__' blocks because they usually contain nothing important anyway and just decrease the coverage % unnecessarily
With 100% coverage :)
Both new and old implementations now pass the strict tests; the old code needed some ugly typing.cast() calls to suppress two valid but useless complaints.
Not sure if this is a good idea. There might be a chicken-vs-egg situation arising from the pip-tools being installed inside the venv we are constructing. We shall see...
It didn't work previously because the GH action script installed dependencies from requirements-dev.txt, but the _package itself_ was never installed; this meant that the project.scripts were never placed into path and thus failed the pytest case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the app for exercise: