Skip to content

Commit

Permalink
fix(lldap): ldap port fix (truecharts#7974)
Browse files Browse the repository at this point in the history
**Description**
<!--
Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that
are required for this change.
-->

Identified a fault with enabled: true against the ldap service in
values.yaml that prevents an install of the app.

⚒️ Fixes  # <!--(issue)-->

**⚙️ Type of change**

- [ ] ⚙️ Feature/App addition
- [X] 🪛 Bugfix
- [ ] ⚠️ Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] 🔃 Refactor of current code

**🧪 How Has This Been Tested?**
<!--
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details
for your test configuration
-->

Tested with CI on my forked repository where the fault was replicated
during the lint check. Made the corrections and checked again with CI
and verbose env enabled which generated no further warnings. (Not sure
how this slipped through with 0.1...)

**📃 Notes:**
<!-- Please enter any other relevant information here -->

**✔️ Checklist:**

- [X] ⚖️ My code follows the style guidelines of this project
- [X] 👀 I have performed a self-review of my own code
- [ ] #️⃣ I have commented my code, particularly in hard-to-understand
areas
- [ ] 📄 I have made corresponding changes to the documentation
- [X] ⚠️ My changes generate no new warnings
- [X] 🧪 I have added tests to this description that prove my fix is
effective or that my feature works
- [x] ⬆️ I increased versions for any altered app according to semantic
versioning

**➕ App addition**

If this PR is an app addition please make sure you have done the
following.

- [ ] 🪞 I have opened a PR on
[truecharts/containers](https://github.com/truecharts/containers) adding
the container to TrueCharts mirror repo.
- [ ] 🖼️ I have added an icon in the Chart's root directory called
`icon.png`

---

_Please don't blindly check all the boxes. Read them and only check
those that apply.
Those checkboxes are there for the reviewer to see what is this all
about and
the status of this PR with a quick glance._
  • Loading branch information
MaverickD650 authored Apr 14, 2023
1 parent 0d14a88 commit 93710cf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/incubator/lldap/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ sources:
- https://github.com/truecharts/charts/tree/master/charts/incubator/lldap
- https://github.com/nitnelave/lldap
type: application
version: 0.1.0
version: 0.1.1
annotations:
truecharts.org/catagories: |
- ldap
Expand Down
3 changes: 2 additions & 1 deletion charts/incubator/lldap/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ service:
targetPort: 17170
port: 17170
ldap:
enabled: true
ports:
enabled: true
ldap:
enabled: true
targetPort: 3890
port: 3890

Expand Down

0 comments on commit 93710cf

Please sign in to comment.