Skip to content

Commit

Permalink
--agree-dev-preview
Browse files Browse the repository at this point in the history
`git grep -i eula` to the rescue
  • Loading branch information
kuba committed Oct 20, 2015
1 parent 9bff9c0 commit aa4641b
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 14 deletions.
1 change: 1 addition & 0 deletions DISCLAIMER
2 changes: 1 addition & 1 deletion Dockerfile-dev
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ RUN /opt/letsencrypt/src/ubuntu.sh && \
# the above is not likely to change, so by putting it further up the
# Dockerfile we make sure we cache as much as possible

COPY setup.py README.rst CHANGES.rst MANIFEST.in requirements.txt EULA linter_plugin.py tox.cover.sh tox.ini pep8.travis.sh .pep8 .pylintrc /opt/letsencrypt/src/
COPY setup.py README.rst CHANGES.rst MANIFEST.in requirements.txt DISCLAIMER linter_plugin.py tox.cover.sh tox.ini pep8.travis.sh .pep8 .pylintrc /opt/letsencrypt/src/

# all above files are necessary for setup.py, however, package source
# code directory has to be copied separately to a subdirectory...
Expand Down
1 change: 0 additions & 1 deletion EULA

This file was deleted.

2 changes: 1 addition & 1 deletion MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ include CHANGES.rst
include CONTRIBUTING.md
include LICENSE.txt
include linter_plugin.py
include letsencrypt/EULA
include letsencrypt/DISCLAIMER
recursive-include docs *
recursive-include letsencrypt/tests/testdata *
2 changes: 1 addition & 1 deletion examples/dev-cli.ini
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ email = foo@example.com
domains = example.com

text = True
agree-eula = True
agree-dev-preview = True
agree-tos = True
debug = True
# Unfortunately, it's not possible to specify "verbose" multiple times
Expand Down
File renamed without changes.
12 changes: 6 additions & 6 deletions letsencrypt/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -763,8 +763,8 @@ def create_parser(plugins, args):
help="Select renewal by default when domains are a superset of a "
"a previously attained cert")
helpful.add(
"automation", "--agree-eula", dest="eula", action="store_true",
help="Agree to the Let's Encrypt Developer Preview EULA")
"automation", "--agree-dev-preview", action="store_true",
help="Agree to the Let's Encrypt Developer Preview Disclaimer")
helpful.add(
"automation", "--agree-tos", dest="tos", action="store_true",
help="Agree to the Let's Encrypt Subscriber Agreement")
Expand Down Expand Up @@ -1060,11 +1060,11 @@ def main(cli_args=sys.argv[1:]):
zope.component.provideUtility(report)
atexit.register(report.atexit_print_messages)

# TODO: remove developer EULA prompt for the launch
if not config.eula:
eula = pkg_resources.resource_string("letsencrypt", "EULA")
# TODO: remove developer preview prompt for the launch
if not config.agree_dev_preview:
disclaimer = pkg_resources.resource_string("letsencrypt", "DISCLAIMER")
if not zope.component.getUtility(interfaces.IDisplay).yesno(
eula, "Agree", "Cancel"):
disclaimer, "Agree", "Cancel"):
raise Error("Must agree to TOS")

if not os.geteuid() == 0:
Expand Down
7 changes: 4 additions & 3 deletions letsencrypt/tests/cli_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def _call(self, args):
from letsencrypt import cli
args = ['--text', '--config-dir', self.config_dir,
'--work-dir', self.work_dir, '--logs-dir', self.logs_dir,
'--agree-eula'] + args
'--agree-dev-preview'] + args
with mock.patch('letsencrypt.cli.sys.stdout') as stdout:
with mock.patch('letsencrypt.cli.sys.stderr') as stderr:
with mock.patch('letsencrypt.cli.client') as client:
Expand All @@ -53,7 +53,7 @@ def _call_stdout(self, args):
from letsencrypt import cli
args = ['--text', '--config-dir', self.config_dir,
'--work-dir', self.work_dir, '--logs-dir', self.logs_dir,
'--agree-eula'] + args
'--agree-dev-preview'] + args
with mock.patch('letsencrypt.cli.sys.stderr') as stderr:
with mock.patch('letsencrypt.cli.client') as client:
ret = cli.main(args)
Expand Down Expand Up @@ -96,7 +96,8 @@ def test_help(self):

def test_configurator_selection(self):
real_plugins = disco.PluginsRegistry.find_all()
args = ['--agree-eula', '--apache', '--authenticator', 'standalone']
args = ['--agree-dev-preview', '--apache',
'--authenticator', 'standalone']

# This needed two calls to find_all(), which we're avoiding for now
# because of possible side effects:
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/_common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ letsencrypt_test () {
--manual-test-mode \
$store_flags \
--text \
--agree-eula \
--agree-dev-preview \
--agree-tos \
--email "" \
--renew-by-default \
Expand Down

0 comments on commit aa4641b

Please sign in to comment.