[ImgBot] optimizes images #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![imgbot[bot]](https://avatars.githubusercontent.com/in/4706?s=60&v=4){kind=small}
*Total -- 73.04kb -> 58.41kb (20.03%) /examples/android/cukeulator/src/main/res/drawable-xxhdpi/ic_launcher.png -- 15.72kb -> 11.93kb (24.11%) /examples/android/android-studio/Cukeulator/app/src/main/res/drawable-xxhdpi/ic_launcher.png -- 15.72kb -> 11.93kb (24.11%) /examples/android/cukeulator/src/main/res/drawable-xhdpi/ic_launcher.png -- 9.07kb -> 7.26kb (19.93%) /examples/android/android-studio/Cukeulator/app/src/main/res/drawable-xhdpi/ic_launcher.png -- 9.07kb -> 7.26kb (19.93%) /examples/android/android-studio/Cukeulator/app/src/main/res/drawable-hdpi/ic_launcher.png -- 6.32kb -> 5.23kb (17.19%) /examples/android/cukeulator/src/main/res/drawable-hdpi/ic_launcher.png -- 6.32kb -> 5.23kb (17.19%) /examples/android/android-studio/Cukeulator/app/src/main/res/drawable-mdpi/ic_launcher.png -- 3.58kb -> 3.13kb (12.39%) /examples/android/cukeulator/src/main/res/drawable-mdpi/ic_launcher.png -- 3.58kb -> 3.13kb (12.39%) /examples/android/android-test/src/main/res/drawable-hdpi/ic_launcher.png -- 3.68kb -> 3.30kb (10.3%)
pull bot
pushed a commit
that referenced
this pull request
Jul 31, 2019
Refactors the Env property sources to allow different property source hierarchy for each runner. These ordering having been chosen such that sensible default values can read from file or 'hardcoded' configuration can be overridden by environment properties, system properties or CLI arguments. CLI property source order: 1 Command line 2 System properties 3 Environment variables 4 cucumber.properties file JUnit and TestNG property source order: 1 System properties 2 Environment variables 3 ``@CucumberOptions` 4 cucumber.properties file Old situation: JUnit, TestNG, and CLI property source order: 1. System properties 2. Environment variables 3. cucumber.properties file 4. CLI arguments or `@CucumberOptions` Additionally in the old situation the commandline arguments in #1,#2,# 3would replace rather then be merged with each other. The result would be merged with #4. This was somewhat confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beep boop. Optimizing your images is my life. https://imgbot.net/ for more information.