Skip to content

Commit

Permalink
Excluded some messages as they were being reported twice
Browse files Browse the repository at this point in the history
  • Loading branch information
gsherwood committed Aug 30, 2019
1 parent a10963b commit 8c9b10a
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
8 changes: 8 additions & 0 deletions src/Standards/PSR12/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,14 @@

<!-- 5.5 foreach -->

<!-- exclude these messages as they are already checked by PSR2.ControlStructures.ControlStructureSpacing -->
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.SpaceAfterOpen">
<severity>0</severity>
</rule>
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.SpaceBeforeClose">
<severity>0</severity>
</rule>

<!-- 5.6 try, catch, finally -->

<!-- 6. Operators -->
Expand Down
12 changes: 10 additions & 2 deletions src/Standards/PSR2/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
<!-- 4.6 Method and Function Calls -->

<!-- When making a method or function call, there MUST NOT be a space between the method or function name and the opening parenthesis, there MUST NOT be a space after the opening parenthesis, and there MUST NOT be a space before the closing parenthesis. In the argument list, there MUST NOT be a space before each comma, and there MUST be one space after each comma.
Argument lists MAY be split across multiple lines, where each subsequent line is indented once. When doing so, the first item in the list MUST be on the next line, and there MUST be only one argument per line. -->
Argument lists MAY be split across multiple lines, where each subsequent line is indented once. When doing so, the first item in the list MUST be on the next line, and there MUST be only one argument per line. -->
<rule ref="Generic.Functions.FunctionCallArgumentSpacing"/>
<rule ref="PSR2.Methods.FunctionCallSignature.SpaceAfterCloseBracket">
<severity>0</severity>
Expand Down Expand Up @@ -179,11 +179,19 @@
<rule ref="Squiz.ControlStructures.LowercaseDeclaration"/>
<!-- checked by PSR2.ControlStructures.ControlStructureSpacing -->

<!-- exclude this message as it is already checked Generic.PHP.LowerCaseKeyword -->
<!-- exclude this message as it is already checked by Generic.PHP.LowerCaseKeyword -->
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.AsNotLower">
<severity>0</severity>
</rule>

<!-- exclude these messages as they are already checked by PSR2.ControlStructures.ControlStructureSpacing -->
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.SpaceAfterOpen">
<severity>0</severity>
</rule>
<rule ref="Squiz.ControlStructures.ForEachLoopDeclaration.SpaceBeforeClose">
<severity>0</severity>
</rule>

<!-- The body of each structure MUST be enclosed by braces. This standardizes how the structures look, and reduces the likelihood of introducing errors as new lines get added to the body. -->
<rule ref="Generic.ControlStructures.InlineControlStructure"/>

Expand Down

0 comments on commit 8c9b10a

Please sign in to comment.