Skip to content

Python 3.14 support #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Python 3.14 support #166

wants to merge 14 commits into from

Conversation

MatthieuDartiailh
Copy link
Owner

@MatthieuDartiailh MatthieuDartiailh commented Jun 23, 2025

Some backward incompatible changes are also introduce regarding:

  • BINARY_OP that now requires a BinaryOp object as argument (for Instr)
  • FORMAT_VALUE that now requires a FormatValue object as argument
    This align the behavior of those instructions with others using an enum and hence requiring one.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 24 lines in your changes missing coverage. Please review.

Project coverage is 94.94%. Comparing base (eec7c30) to head (7077a51).

Files with missing lines Patch % Lines
src/bytecode/instr.py 70.83% 8 Missing and 6 partials ⚠️
src/bytecode/concrete.py 37.50% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   96.14%   94.94%   -1.20%     
==========================================
  Files           7        7              
  Lines        2074     2136      +62     
  Branches      474      479       +5     
==========================================
+ Hits         1994     2028      +34     
- Misses         42       61      +19     
- Partials       38       47       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MatthieuDartiailh
Copy link
Owner Author

MatthieuDartiailh commented Jun 29, 2025

3.14 tests are passing locally with 3.14.0b3 without coverage measurement

@makslevental
Copy link

makslevental commented Jul 24, 2025

Hey just curious is this ready to land? Anything I can do to help it along?

@MatthieuDartiailh
Copy link
Owner Author

Some test regarding FORMAT_VALUE and BUILD_INTERPOLATION are missing. The changelog need to be updated too and I did not review the docs. If you want to help with the tests you are welcome.

@makslevental
Copy link

Will do - will send soon :)

@MatthieuDartiailh
Copy link
Owner Author

Actually tests are also missing for validation of the argument of the following instructions: BINARY_OP, FORMAT_VALUE, SPECIAL_METHOD, COMMON_CONSTANT, LOAD_SMALL_INT
For this you can extend: test_instr.py::InstrTest.test_invalid_arg

Comment on lines +212 to +215
if opcode.opmap[name] in FORMAT_VALUE_OPS:
Instr(name, (True, FormatValue.ASCII))
else:
Instr(name, (True, "arg"))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you did/do already have a test for arg validation for FORMAT_VALUE :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some more tests anyway #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants