-
-
Notifications
You must be signed in to change notification settings - Fork 47
Python 3.14 support #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Python 3.14 support #166
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 96.14% 94.94% -1.20%
==========================================
Files 7 7
Lines 2074 2136 +62
Branches 474 479 +5
==========================================
+ Hits 1994 2028 +34
- Misses 42 61 +19
- Partials 38 47 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3.14 tests are passing locally with 3.14.0b3 without coverage measurement |
Hey just curious is this ready to land? Anything I can do to help it along? |
Some test regarding FORMAT_VALUE and BUILD_INTERPOLATION are missing. The changelog need to be updated too and I did not review the docs. If you want to help with the tests you are welcome. |
Will do - will send soon :) |
Actually tests are also missing for validation of the argument of the following instructions: BINARY_OP, FORMAT_VALUE, SPECIAL_METHOD, COMMON_CONSTANT, LOAD_SMALL_INT |
if opcode.opmap[name] in FORMAT_VALUE_OPS: | ||
Instr(name, (True, FormatValue.ASCII)) | ||
else: | ||
Instr(name, (True, "arg")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI you did/do already have a test for arg validation for FORMAT_VALUE
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some more tests anyway #167
Some backward incompatible changes are also introduce regarding:
This align the behavior of those instructions with others using an enum and hence requiring one.