Forex, Futures, Crypto and Stock updates#51
Forex, Futures, Crypto and Stock updates#51mccabe93 wants to merge 13 commits intoMatthiWare:masterfrom
Conversation
- Realtime quotes for crypto and stock. - Futures and Forex support for realtime and historical quotes
| </PackageReleaseNotes> | ||
| <AssemblyName>FinancialModelingPrep</AssemblyName> | ||
| </PropertyGroup> | ||
| <PropertyGroup> |
|
|
||
| public async Task<ApiResponse<List<StockQuoteResponse>>> GetQuoteAsync(string symbol) | ||
| { | ||
| const string url = "[version]/quote/[symbol]"; |
There was a problem hiding this comment.
This endpoint already exists under api.CompanyValuation.GetQuoteAsync
| public interface ICryptoMarketProvider | ||
| { | ||
| public Task<ApiResponse<List<CryptoItem>>> GetAvilableCryptocurrencies(); | ||
| Task<ApiResponse<List<CryptoItem>>> GetAvilableCryptocurrenciesAsync(); |
There was a problem hiding this comment.
Task<ApiResponse<List<CryptoItem>>> GetAvailableCryptocurrenciesAsync();
| } | ||
|
|
||
| public Task<ApiResponse<CryptoHistoricalPriceDailyItem>> GetDailyPrices(string symbol) | ||
| public async Task<ApiResponse<List<CryptoQuoteResponse>>> GetQuoteAsync(string symbol) |
There was a problem hiding this comment.
If you just await the Task without doing anything with it you can remove the async/await keywords here.
Only the first caller in the call stack that needs to do something with the result needs to await it.
|
|
||
| namespace MatthiWare.FinancialModelingPrep.Abstractions.Model | ||
| { | ||
| public interface ICurrentQuote |
There was a problem hiding this comment.
No need to have this interface, just create the different models with the properties that they have.
Futures/Forex Quote models should not be forced to implement the Eps or PE properties
Matthiee
added
enhancement
|
Hi @mccabe93 The build is failing, also please check my previous review remarks, they have not been fixed yet. |
- Fixed up a couple unit tests to align with changes.
2 participants
Some cleanup and refactoring. Replaced doubles with decimals, fixed a typo (succes -> success)