Improve after print handling #780

sensasi-delight · 2025-01-07T12:46:14Z

This pull request resolves #779, which was caused by changes in #764, by separating the logic for mobile and desktop browsers. Additionally, I’ve improved the solution from PR #764 by using setTimeout instead of addEventListener to ensure proper execution after printing on mobile browsers.

I’ve also refactored repetitive code to make it cleaner and more maintainable.

Tested Successfully On:

 - Windows 11:
   - Chrome v131
   - Edge v131
   - Vivaldi v6
   - Vivaldi v7
- Android:
  - Chrome v131

… logic

MatthewHerbst

I've filed an upstream bug report to Vivaldi (VB-112980). If we don't hear from them in the next few days I'll merge this.

src/utils/startPrint.ts

Improve print handling for mobile browsers and refactor 'after print'…

3248337

… logic

MatthewHerbst reviewed Jan 25, 2025

View reviewed changes

src/utils/startPrint.ts Show resolved Hide resolved

MatthewHerbst approved these changes Jan 27, 2025

View reviewed changes

MatthewHerbst merged commit 2dbeb29 into MatthewHerbst:master Jan 27, 2025

sensasi-delight deleted the patch779 branch January 28, 2025 11:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve after print handling #780

Improve after print handling #780

sensasi-delight commented Jan 7, 2025 •

edited

Loading

MatthewHerbst left a comment

Improve after print handling #780

Improve after print handling #780

Conversation

sensasi-delight commented Jan 7, 2025 • edited Loading

MatthewHerbst left a comment

Choose a reason for hiding this comment

sensasi-delight commented Jan 7, 2025 •

edited

Loading