Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a new option that adds support for copying shadow root content #723

Merged
merged 8 commits into from
Aug 19, 2024
Merged

Implement a new option that adds support for copying shadow root content #723

merged 8 commits into from
Aug 19, 2024

Conversation

boehlke
Copy link
Contributor

@boehlke boehlke commented Aug 14, 2024 •
edited
Loading

Resolves #176

MatthewHerbst
MatthewHerbst reviewed Aug 19, 2024
View reviewed changes
Copy link
Owner

@MatthewHerbst MatthewHerbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! Just a few things to cleanup please, mostly we need to add the docs for it to the README

boehlke and others added 4 commits August 19, 2024 09:57
@boehlke @MatthewHerbst
Code Review Changes
a6db0b4 
Co-authored-by: Matthew Herbst <MatthewHerbst@users.noreply.github.com>
@boehlke @MatthewHerbst
Code Review Changes
1fd9d99 
Co-authored-by: Matthew Herbst <MatthewHerbst@users.noreply.github.com>
@boehlke
Address code review issues, mostly clone optimization/simplification
52f526d
@boehlke
Add copyShadowRoots to documentation. Add warning
f15e2b2
MatthewHerbst
MatthewHerbst approved these changes Aug 19, 2024
View reviewed changes
Copy link
Owner

@MatthewHerbst MatthewHerbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! I'll get it into a beta-3 release this evening 🥳

@MatthewHerbst MatthewHerbst merged commit a5740bf into MatthewHerbst:master Aug 19, 2024
@MatthewHerbst
Copy link
Owner

Published in v3.0.0-beta-3 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewHerbst MatthewHerbst MatthewHerbst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

React component wrapped inside custom element (web component)
2 participants
@boehlke @MatthewHerbst