[#186940377] - Install chrome browser to run karma unit tests#4
Open
HasibAhmed577 wants to merge 1 commit intoteamcity-agent-node-version-updatefrom
Open
Conversation
HasibAhmed577
changed the base branch from
master
to
teamcity-agent-node-version-update
muttakee09
approved these changes
Jun 13, 2024
basilard99
approved these changes
Jun 13, 2024
ldscavo
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story: [#186940377] - Fix TeamCity Unit Test Failures for new Agent running Node 6.17.1.
For some package changes in this PR we need a browser that can run typescript code. We have installed Chome in this PR to fulfill that purpose.
The code related to karma configuration can be found in this PR: https://github.com/MatrixSolutions/Matrix-Web/pull/11869